On Thu, Aug 25, 2022 at 8:28 AM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote: > > Hi Wei, > > Apologies for failing to answer to your previous email and for the delay > on this one, I just found out GMail had classified them as spam :(. > > So as for your last message, yes: your understanding of my previous > answer was correct. Thanks for the patch below! Some comments inline. > Do we really want to add such a specific command to bpftool that would attach BPF object files with programs of only RAW_TRACEPOINT and RAW_TRACEPOINT_WRITABLE type? I could understand if we added something that would be equivalent of BPF skeleton's auto-attach method. That would make sense in some contexts, especially for some quick testing and validation, to avoid writing (a rather simple) user-space loading code. But "perf attach" for raw_tp programs only? Seem way too limited and specific, just adding bloat to bpftool, IMO. > On 24/08/2022 04:38, Wei Yongjun wrote: > > This patch introduces a new bpftool command: perf attach, > > which used to attaching/pinning tracepoints programs. > > > > bpftool perf attach PROG TP_NAME FILE > > > > It will attach bpf program PROG to tracepoint TP_NAME and > > pin tracepoint program as FILE, FILE must be located in > > bpffs mount. > > [...]
