Re: [PATCH bpf-next v2] bpf: Fix a few typos in BPF helpers documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/08/2022 15:57, Alexei Starovoitov wrote:
> On Thu, Aug 25, 2022 at 4:02 AM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote:
>> index 4fb685591035..0487ee06edef 100644
>> --- a/tools/include/uapi/linux/bpf.h
>> +++ b/tools/include/uapi/linux/bpf.h
>> @@ -79,7 +79,7 @@ struct bpf_insn {
>>  /* Key of an a BPF_MAP_TYPE_LPM_TRIE entry */
>>  struct bpf_lpm_trie_key {
>>         __u32   prefixlen;      /* up to 32 for AF_INET, 128 for AF_INET6 */
>> -       __u8    data[0];        /* Arbitrary size */
>> +       __u8    data[]; /* Arbitrary size */
> 
> Sigh. Looks like you didn't even run the build of selftests.
> Please see relevant commits in bpf tree.

The rest of the patch is a fix on typos, in comments, so indeed I did
not :/. I missed the commit from Daniel and should have been more
cautious about the above, apologies. I'll send a new version without it.

Quentin



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux