On Tue, Aug 23, 2022 at 9:23 AM Martin KaFai Lau <kafai@xxxxxx> wrote: > > On Mon, Aug 22, 2022 at 12:45:10PM -0700, Stanislav Fomichev wrote: > > +const struct bpf_func_proto bpf_get_cgroup_classid_curr_proto __weak; > There is a 'ifdef CONFIG_CGROUP_NET_CLASSID' before using this proto. > This should be not needed also. Please check. > > However, a declaration is probably needed in include/linux/bpf.h. Yeah, you're right, having one __weak somewhere + extern in the header is enough. Will add extern for this one and remove these __weak definitions (from both patches). > > const struct bpf_func_proto bpf_get_current_cgroup_id_proto __weak; > > +const struct bpf_func_proto bpf_get_current_ancestor_cgroup_id_proto __weak; > This one should be unnecessary also. > > Others lgtm. > > Acked-by: Martin KaFai Lau <kafai@xxxxxx> Thank you for the review!
