On Sun, Aug 21, 2022 at 4:35 AM Shmulik Ladkani <shmulik@xxxxxxxxxxxxxxxx> wrote: > > Currently, attaching BPF_PROG_TYPE_FLOW_DISSECTOR programs completely > replaces the flow-dissector logic with custom dissection logic. > This forces implementors to write programs that handle dissection for > any flows expected in the namespace. > > It makes sense for flow-dissector bpf programs to just augment the > dissector with custom logic (e.g. dissecting certain flows or custom > protocols), while enjoying the broad capabilities of the standard > dissector for any other traffic. > > v2: > - Extend selftests/bpf/progs/bpf_flow.c to exercise new ret code The series looks good to me, thank you! Reviewed-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
