Re: [PATCH bpf-next 2/2] bpf/flow_dissector: Introduce BPF_FLOW_DISSECTOR_CONTINUE retcode for flow-dissector bpf progs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 18 Aug 2022 09:12:43 -0700
Stanislav Fomichev <sdf@xxxxxxxxxx> wrote:

> Some historic perspective: the original goal was to explicitly not
> fallback to the c code.
> It seems like it should be fine with this extra return code.
> But let's also extend tools/testing/selftests/bpf/progs/bpf_flow.c
> with a case that exercises this new return code?

OK, will re-submit with a test.

> Is it too late to also amend verifier's check_return_code to allow
> only a small subset of return types for flow-disccestor program type?

Well, wouldn't that be too late now? there might be progs out there with
different codes. In any case, I don't think adding this is related to this
series.

Best,
Shmulik



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux