Re: [PATCH bpf-next 3/4] libbpf: clean up deprecated and legacy aliases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 16, 2022 at 2:34 PM Hao Luo <haoluo@xxxxxxxxxx> wrote:
>
> On Mon, Aug 15, 2022 at 9:23 PM Andrii Nakryiko <andrii@xxxxxxxxxx> wrote:
> >
> > Remove two missed deprecated APIs that were aliased to new APIs:
> > bpf_object__unload and bpf_prog_attach_xattr.
> >
>
> Three functions? Missing btf__load()?

Apparently I suck at counting, thanks for spotting. It doesn't seem
worth it to send v2 just for this, maybe Alexei or Daniel can fix it
up while applying.

>
> > Also move legacy API libbpf_find_kernel_btf (aliased to
> > btf__load_vmlinux_btf) into libbpf_legacy.h.
> >
> > Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> > ---
>
> The change itself looks good to me. Verified these functions are no
> longer used in the source file.
>
> Acked-by: Hao Luo <haoluo@xxxxxxxxxx>
>
>
> >  tools/lib/bpf/bpf.c           | 5 -----
> >  tools/lib/bpf/btf.c           | 2 --
> >  tools/lib/bpf/btf.h           | 1 -
> >  tools/lib/bpf/libbpf.c        | 2 --
> >  tools/lib/bpf/libbpf_legacy.h | 2 ++
> >  5 files changed, 2 insertions(+), 10 deletions(-)
> >

[...]



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux