Re: [PATCH] net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()
From: David Howells <dhowells@xxxxxxxxxx>
Date: Tue, 16 Aug 2022 14:09:46 +0100
Cc: dhowells@xxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Martin KaFai Lau <kafai@xxxxxx>, Song Liu <songliubraving@xxxxxx>, Yonghong Song <yhs@xxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel-mentees@xxxxxxxxxxxxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx
In-reply-to: <20220816103452.479281-1-yin31149@gmail.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Hawkins Jiawei <yin31149@xxxxxxxxx> wrote:

>  	if (socks) {
>  		WRITE_ONCE(sk->sk_user_data, NULL);

Btw, shouldn't this be rcu_assign_pointer() or RCU_INIT_POINTER(), not
WRITE_ONCE()?

David

Follow-Ups:
- Re: [PATCH] net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()
  - From: Martin KaFai Lau

References:
- Re: [PATCH] net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()
  - From: Hawkins Jiawei

Prev by Date: Re: [RFC PATCH v1 1/3] bpf: Make ring buffer overwritable.
Next by Date: Re: [PATCH v2 2/4] bpf: Add bpf_user_ringbuf_drain() helper
Previous by thread: Re: [PATCH] net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()
Next by thread: Re: [PATCH] net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]