On Mon, 15 Aug 2022 08:35:53 -0700 Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > Then make it a notrace function with a nop5 in it. That isn't hard. > > That's exactly what we're trying to do. > Jiri's patch is one way to achieve that. > What is your suggestion? > Move it from C to asm ? > Make it naked function with explicit inline asm? > What else? The dispatcher is already in the kernel so it's too late to complain about it. Jiri's patch (with my extensions) will hopefully fix the breakage BPF did to ftrace. My ask now is to be more inclusive when doing anything that deals with modification of text, or other infrastructures. This "go it alone" approach really needs to stop. Linux is an open source project and collaboration is key. I know you don't care about others use cases (as you told me in that BPF meeting last year), but any maintainer in the Linux kernel must care about the use case of others or this will all fail. -- Steve
