On Mon, Aug 1, 2022 at 12:34 PM Hao Luo <haoluo@xxxxxxxxxx> wrote: > > On Mon, Aug 1, 2022 at 10:39 AM Stanislav Fomichev <sdf@xxxxxxxxxx> wrote: > > > > Apparently, no existing selftest covers it. Add a new one where > > we load cgroup/bind4 program and attach fentry to it. > > Calling bpf_obj_get_info_by_fd on the fentry program > > should return non-zero btf_id/btf_obj_id instead of crashing the kernel. > > > > v2: > > - use ret instead of err in find_prog_btf_id (Hao) > > - remove verifier log (Hao) > > - drop if conditional from ASSERT_OK(bpf_obj_get_info_by_fd(...)) (Hao) > > > > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx> > > I see Martin has comments based on v1, but v2 looks good to me. > > Acked-by: Hao Luo <haoluo@xxxxxxxxxx> Thank you for the review! I'll move some stuff around for v3, so I'll have to ask you to have one more :-(
