Hi Kumar, On Mon, Aug 1, 2022, at 8:51 AM, Kumar Kartikeya Dwivedi wrote: > On Sat, 30 Jul 2022 at 21:40, Daniel Xu <dxu@xxxxxxxxx> wrote: >> >> Test that the prog can read/write to/from the connection mark. This >> test is nice because it ensures progs can interact with netfilter >> subsystem correctly. >> > > Commit message is a bit misleading, where are you writing to ct->mark? :) > The cover letter also mentions "reading and writing from nf_conn". Do > you have patches whitelisting nf_conn::mark for writes? > If not, drop the writing related bits from the commit log. The rest > looks ok to me. Ah good catch, thanks. I've neglected to actually test writing to the mark. I'll follow up with another patch to enable writing to mark and testing it. And in meantime let's just change the commit msg on this patchset. I'm in the middle of a move right now so I probably can't respin the patch for a few more days. Feel free to edit the commit msgs. Or I'll send it again when I set my computer up. [...] Thanks, Daniel
