Hi, On 2022-07-05 00:12:37 +0200, Jiri Olsa wrote: > On Mon, Jul 04, 2022 at 01:19:22PM -0700, Andres Freund wrote: > > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > > > index ee417c321adb..2aa0bad11f05 100644 > > > --- a/tools/perf/Makefile.config > > > +++ b/tools/perf/Makefile.config > > > @@ -914,8 +914,6 @@ ifndef NO_LIBBFD > > > FEATURE_CHECK_LDFLAGS-disassembler-init-styled += -liberty -lz -ldl > > > endif > > > endif > > > - $(call feature_check,disassembler-four-args) > > > - $(call feature_check,disassembler-init-styled) > > > endif > > > > > > ifeq ($(feature-libbfd-buildid), 1) > > > @@ -1025,6 +1023,9 @@ ifdef HAVE_KVM_STAT_SUPPORT > > > CFLAGS += -DHAVE_KVM_STAT_SUPPORT > > > endif > > > > > > +$(call feature_check,disassembler-four-args) > > > +$(call feature_check,disassembler-init-styled) > > > + > > > ifeq ($(feature-disassembler-four-args), 1) > > > CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE > > > endif > > > > This I don't understand - why do we want these to run under NO_LIBBFD etc? > > when I was quickly testing that I did not have any of them detected > and got compile fail.. so I moved it to safe place ;-) it might be > placed in smarter place I think that's because you'd removed them from FEATURE_TESTS_BASIC in Makefile.feature. In v3 I just sent out I just removed them from FEATURE_DISPLAY, without any more "structural" changes in tools/perf/Makefile.config. Greetings, Andres Freund
