Currently struct arguments are not supported for trampoline based progs.
One of major reason is that struct argument may pass by value which may
use more than one registers. This breaks trampoline progs where
each argument is assumed to take one register. bcc community reported the
issue ([1]) where struct argument is not supported for fentry program.
typedef struct {
uid_t val;
} kuid_t;
typedef struct {
gid_t val;
} kgid_t;
int security_path_chown(struct path *path, kuid_t uid, kgid_t gid);
Inside Meta, we also have a use case to attach to tcp_setsockopt()
typedef struct {
union {
void *kernel;
void __user *user;
};
bool is_kernel : 1;
} sockptr_t;
int tcp_setsockopt(struct sock *sk, int level, int optname,
sockptr_t optval, unsigned int optlen);
This patch added struct value support for bpf tracing programs which
uses trampoline. struct argument size needs to be 16 or less so
it can fit in one or two registers. Based on analysis on llvm and
experiments, atruct argument size greater than 16 will be passed
as pointer to the struct.
Please see patch #4 and selftests for specific examples.
I labelled the patch as RFC so I can get some comments before proceeding.
The patch set is not complete as:
(1). it does not support struct arguments which are passed in as pointers.
(2). there might be some corner cases where on x86_64 even 16 bytes may
pass by pointers. This needs further investigation.
(3). tests are imcomplete, no fexit or fmod tests.
[1] https://github.com/iovisor/bcc/issues/3657
[2] https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/TargetInfo.cpp
Yonghong Song (7):
bpf: Always return corresponding btf_type in __get_type_size()
bpf: Add struct argument info in btf_func_model
bpf: x86: Rename stack_size to regs_off in {save,restore}_regs()
bpf: x86: Support in-register struct arguments
bpf: arm64: No support of struct value argument
bpf: Populate struct value info in btf_func_model
selftests/bpf: Add struct value tests with fentry programs.
arch/arm64/net/bpf_jit_comp.c | 4 +
arch/x86/net/bpf_jit_comp.c | 173 ++++++++++++++++--
include/linux/bpf.h | 9 +
kernel/bpf/btf.c | 54 +++++-
.../selftests/bpf/bpf_testmod/bpf_testmod.c | 37 ++++
.../selftests/bpf/prog_tests/tracing_struct.c | 51 ++++++
.../selftests/bpf/progs/tracing_struct.c | 64 +++++++
7 files changed, 365 insertions(+), 27 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/tracing_struct.c
create mode 100644 tools/testing/selftests/bpf/progs/tracing_struct.c
--
2.30.2
