Re: [PATCH bpf-next v1] bpf: Tidy up verifier check_func_arg()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 12, 2022 at 6:10 PM Joanne Koong <joannelkoong@xxxxxxxxx> wrote:
>
> On Tue, Jul 12, 2022 at 3:44 PM <sdf@xxxxxxxxxx> wrote:
> >
> > On 07/12, Joanne Koong wrote:
> > > This patch does two things:
> >
> > > 1. For matching against the arg type, the match should be against the
> > > base type of the arg type, since the arg type can have different
> > > bpf_type_flags set on it.
> >
> > Does this need a fixes tag? Something around the following maybe:
> >
> > Fixes: d639b9d13a39 ("bpf: Introduce composable reg, ret and arg types.")
> >
> > ?
> I will add that tag. Thanks!

Joanne and Stan, IMO this is not necessary. I think this change is a
cleanup rather than a fix.

> >
> > > 2. Uses switch casing to improve readability + efficiency.
> >
> > > Signed-off-by: Joanne Koong <joannelkoong@xxxxxxxxx>
> > > ---
[...]
> >



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux