> On Mon, Jun 27, 2022 at 11:37:31AM +0900, Masami Hiramatsu wrote: > On Sat, 25 Jun 2022 17:24:29 +0200 > Dmitrii Dolgov <9erthalion6@xxxxxxxxx> wrote: > > > From: Song Liu <songliubraving@xxxxxx> > > > > Enable specifying maxactive for fd based kretprobe. This will be useful > > for tracing tools like bcc and bpftrace (see for example discussion [1]). > > Use highest 4 bit (bit 59-63) to allow specifying maxactive by log2. > > > > The original patch [2] seems to be fallen through the cracks and wasn't > > applied. I've merely rebased the work done by Song Liu, verififed it > > still works, and modified to allow specifying maxactive by log2 per > > suggestion from the discussion thread. > > > > Note that changes in rethook implementation may render maxactive > > obsolete. > > > > [1]: https://github.com/iovisor/bpftrace/issues/835 > > [2]: https://lore.kernel.org/all/20191007223111.1142454-1-songliubraving@xxxxxx/ > > > > Signed-off-by: Song Liu <songliubraving@xxxxxx> > > Signed-off-by: Dmitrii Dolgov <9erthalion6@xxxxxxxxx> > > This looks good to me. > > Reviewed-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> Thanks. Is there anything else I can help with to get this change committed?
