Re: [PATCH bpf 1/4] bpf: Fix incorrect verifier simulation around jmp32's jeq/jne

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello:

This series was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@xxxxxxxxxx>:

On Fri,  1 Jul 2022 14:47:24 +0200 you wrote:
> Kuee reported a quirk in the jmp32's jeq/jne simulation, namely that the
> register value does not match expectations for the fall-through path. For
> example:
> 
> Before fix:
> 
>   0: R1=ctx(off=0,imm=0) R10=fp0
>   0: (b7) r2 = 0                        ; R2_w=P0
>   1: (b7) r6 = 563                      ; R6_w=P563
>   2: (87) r2 = -r2                      ; R2_w=Pscalar()
>   3: (87) r2 = -r2                      ; R2_w=Pscalar()
>   4: (4c) w2 |= w6                      ; R2_w=Pscalar(umin=563,umax=4294967295,var_off=(0x233; 0xfffffdcc),s32_min=-2147483085) R6_w=P563
>   5: (56) if w2 != 0x8 goto pc+1        ; R2_w=P571  <--- [*]
>   6: (95) exit
>   R0 !read_ok
> 
> [...]

Here is the summary with links:
  - [bpf,1/4] bpf: Fix incorrect verifier simulation around jmp32's jeq/jne
    https://git.kernel.org/bpf/bpf/c/a12ca6277eca
  - [bpf,2/4] bpf: Fix insufficient bounds propagation from adjust_scalar_min_max_vals
    https://git.kernel.org/bpf/bpf/c/3844d153a41a
  - [bpf,3/4] bpf, selftests: Add verifier test case for imm=0,umin=0,umax=1 scalar
    https://git.kernel.org/bpf/bpf/c/73c4936f916d
  - [bpf,4/4] bpf, selftests: Add verifier test case for jmp32's jeq/jne
    https://git.kernel.org/bpf/bpf/c/a49b8ce7306c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux