Hey Maciej,
On 6/29/22 11:41 AM, Maciej Fijalkowski wrote:
On Mon, Jun 27, 2022 at 02:15:13PM -0700, Andrii Nakryiko wrote:
Remove deprecated xsk APIs from libbpf. But given we have selftests
relying on this, move those files (with minimal adjustments to make them
compilable) under selftests/bpf.
We also remove all the removed APIs from libbpf.map, while overall
keeping version inheritance chain, as most APIs are backwards
compatible so there is no need to reassign them as LIBBPF_1.0.0 versions.
Hey Andrii,
First of all, great that you are moving this over to selftests where we
can use this as the base for our upcoming control path tests. However,
during some of our selftests work we have found a bug in the xsk part of
libbpf that you're moving here. What is the way forward to fixing this
from your perspective? Should we wait once this set lands so that we would
fix this in the xsk.c file in selftests/bpf? Or would you pick the bugfix
before doing the move?
Just to answer this question, fwiw, the set has been applied yesterday to bpf-next
tree [0], so from an upstream PoV, please send a relative fix for xsk.c file in
selftests/bpf/.
Thanks,
Daniel
[0] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=f36600634282a519e1b0abea609acdc8731515d7
