On Fri, Jun 24, 2022 at 02:09:33PM -0700, Andrii Nakryiko wrote: > On Wed, Jun 22, 2022 at 10:22 AM Daniel Müller <deso@xxxxxxxxxx> wrote: > > > > On Tue, Jun 21, 2022 at 12:41:22PM -0700, Joanne Koong wrote: > > > On Mon, Jun 20, 2022 at 4:25 PM Daniel Müller <deso@xxxxxxxxxx> wrote: > > > > > > + > > > > + return local_len == targ_len && strncmp(local_n, targ_n, local_len) == 0; > > > Does calling "return !strcmp(local_n, targ_n);" do the same thing here? > > > > I think it does. Changed. Thanks! > > No, it doesn't. task_struct___kernel and task_struct___libbpf will > have same local_len and targ_len and should be considered a name > match, but strcmp() will return false. That strncmp() is there for a > very good reason. Ah, I actually misread the request to be for keeping strncmp(), but omitting the explicit length equality check beforehand. That's how I updated the code. [...] Daniel
