On Fri, 17 Jun 2022 12:06:51 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Wed, 8 Jun 2022 01:11:02 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
>
> >
> > static void sample_entry_handler(struct fprobe *fp, unsigned long ip, struct pt_regs *regs)
> > {
> > - pr_info("Enter <%pS> ip = 0x%p\n", (void *)ip, (void *)ip);
> > + if (use_trace)
> > + trace_printk("Enter <%pS> ip = 0x%p\n", (void *)ip, (void *)ip);
>
> Could we add a comment stating something like "this is just an example, no
> kernel code should call trace_printk() except when actively debugging".
Indeed. I also add a description for this option so that user can
understand this is just a debug option.
Thank you,
--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
