Hi KP, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/KP-Singh/Add-bpf_getxattr/20220621-093013 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-randconfig-a015-20220620 (https://download.01.org/0day-ci/archive/20220621/202206211035.p3LxbVfK-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af6d2a0b6825e71965f3e2701a63c239fa0ad70f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/dd49d2ffb18adceafa98bd517008f59aa9bc910b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review KP-Singh/Add-bpf_getxattr/20220621-093013 git checkout dd49d2ffb18adceafa98bd517008f59aa9bc910b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/trace/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> kernel/trace/bpf_trace.c:1185:25: warning: no previous prototype for function 'bpf_getxattr' [-Wmissing-prototypes] noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, ^ kernel/trace/bpf_trace.c:1185:17: note: declare 'static' if the function is not intended to be used outside of this translation unit noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, ^ static 1 warning generated. vim +/bpf_getxattr +1185 kernel/trace/bpf_trace.c 1184 > 1185 noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, 1186 const char *name, void *value, int size) 1187 { 1188 return __vfs_getxattr(dentry, inode, name, value, size); 1189 } 1190 -- 0-DAY CI Kernel Test Service https://01.org/lkp
