On Fri, Jun 17, 2022 at 11:28:18AM -0700, Stanislav Fomichev wrote: > > > +void bpf_cgroup_atype_get(u32 attach_btf_id, int cgroup_atype) > > > +{ > > > +} > > > + > > > +void bpf_cgroup_atype_put(int cgroup_atype) > > > +{ > > > +} > > From the test bot report, these two empty functions may need > > to be inlined in a .h or else the caller needs to have a CONFIG_CGROUP_BPF > > before calling bpf_cgroup_atype_get(). The bpf-cgroup.h may be a better place > > than bpf.h for the inlines but not sure if it is easy to be included in > > trampoline.c or core.c. Whatever way makes more sense. Either .h is fine. > > Yeah, I already moved them into headers after the complaints from the > bot. Thanks for double checking! > > Let's keep in bpf.h ? ok.