On Thu, Jun 16, 2022 at 4:55 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Thu, Jun 16, 2022 at 2:07 PM Ian Rogers <irogers@xxxxxxxxxx> wrote: > > > > On Thu, Jun 16, 2022 at 2:00 PM Andrii Nakryiko > > <andrii.nakryiko@xxxxxxxxx> wrote: > > > > > > On Tue, Jun 14, 2022 at 1:41 PM Ian Rogers <irogers@xxxxxxxxxx> wrote: > > > > > > > > On Fri, Jun 3, 2022 at 11:30 AM <patchwork-bot+netdevbpf@xxxxxxxxxx> wrote: > > > > > > > > > > Hello: > > > > > > > > > > This patch was applied to bpf/bpf-next.git (master) > > > > > by Andrii Nakryiko <andrii@xxxxxxxxxx>: > > > > > > > > > > On Thu, 2 Jun 2022 22:51:56 -0700 you wrote: > > > > > > From: Yuze Chi <chiyuze@xxxxxxxxxx> > > > > > > > > > > > > Move the correct definition from linker.c into libbpf_internal.h. > > > > > > > > > > > > Reported-by: Yuze Chi <chiyuze@xxxxxxxxxx> > > > > > > Signed-off-by: Yuze Chi <chiyuze@xxxxxxxxxx> > > > > > > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx> > > > > > > > > > > > > [...] > > > > > > > > > > Here is the summary with links: > > > > > - [v2] libbpf: Fix is_pow_of_2 > > > > > https://git.kernel.org/bpf/bpf-next/c/f913ad6559e3 > > > > > > > > > > You are awesome, thank you! > > > > > > > > Will this patch get added to 5.19? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/lib/bpf/libbpf.c#n4948 > > > > > > > > > > I've applied it to bpf-next, so as it stands right now - no. Do you > > > need this for perf? > > > > Nope. We carry it as a patch against 5.19 in Google and was surprised > > to see I didn't need to drop the patch. Our internal code had > > encountered the bug, hence needing the fix. I'd expect others could > > encounter it, but I'm unaware of an issue with it and perf. > > > > So the fix is in Github mirror ([0]) and it is expected that everyone > is using libbpf based on Github repo, so not sure why you'd care about > this fix in bpf tree. I somehow assumed that you need it due to perf, > but was a bit surprised that perf is affected because I don't think > it's using BPF ringbuf. > > So I guess the question I have is why you don't use libbpf from [0] > and what can be done to switch to the official libbpf repo? > > [0] https://github.com/libbpf/libbpf Agreed on not following Linus' tree for libbpf. Not sure about having such an obvious bug in Linus' tree. Thanks, Ian > > Thanks, > > Ian > > > > > > Thanks, > > > > Ian > > > > > > > > > -- > > > > > Deet-doot-dot, I am a bot. > > > > > https://korg.docs.kernel.org/patchwork/pwbot.html > > > > > > > > > >
