On Fri, Jun 10, 2022 at 5:15 PM Maciej Fijalkowski
<maciej.fijalkowski@xxxxxxxxx> wrote:
>
> Commit 1034b03e54ac ("selftests: xsk: Simplify cleanup of ifobjects") removed
> close on netns fd, which is not correct, so let us restore it.
Acked-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
> ---
> tools/testing/selftests/bpf/xdpxceiver.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selftests/bpf/xdpxceiver.c
> index da8098f1b655..2499075fad82 100644
> --- a/tools/testing/selftests/bpf/xdpxceiver.c
> +++ b/tools/testing/selftests/bpf/xdpxceiver.c
> @@ -1591,6 +1591,8 @@ static struct ifobject *ifobject_create(void)
> if (!ifobj->umem)
> goto out_umem;
>
> + ifobj->ns_fd = -1;
> +
> return ifobj;
>
> out_umem:
> @@ -1602,6 +1604,8 @@ static struct ifobject *ifobject_create(void)
>
> static void ifobject_delete(struct ifobject *ifobj)
> {
> + if (ifobj->ns_fd != -1)
> + close(ifobj->ns_fd);
> free(ifobj->umem);
> free(ifobj->xsk_arr);
> free(ifobj);
> --
> 2.27.0
>
