On Thu, May 26, 2022 at 11:34:48PM +0200, Lorenzo Bianconi wrote: > Changes since v3: > - split bpf_xdp_ct_add in bpf_xdp_ct_alloc/bpf_skb_ct_alloc and > bpf_ct_insert_entry > - add verifier code to properly populate/configure ct entry > - improve selftests Kumar, Lorenzo, are you planning on sending v5 ? The patches 1-5 look good. Patch 6 is questionable as Florian pointed out. What is the motivation to allow writes into ct->status? The selftest doesn't do that anyway. Patch 7 (acquire-release pairs) is too narrow. The concept of a pair will not work well. There could be two acq funcs and one release. Please think of some other mechanism. Maybe type based? BTF? Or encode that info into type name? or some other way.
