Hi Joanne, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Joanne-Koong/Update-bhash2-when-socket-s-rcv-saddr-changes/20220602-050108 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7e062cda7d90543ac8c7700fc7c5527d0c0f22ad config: hexagon-defconfig (https://download.01.org/0day-ci/archive/20220602/202206020958.MfddzQxe-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c825abd6b0198fb088d9752f556a70705bc99dfd) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d4e9d3ab2c5210670fbe995cc8b13310a5aa6310 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Joanne-Koong/Update-bhash2-when-socket-s-rcv-saddr-changes/20220602-050108 git checkout d4e9d3ab2c5210670fbe995cc8b13310a5aa6310 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/ipv4/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> net/ipv4/inet_hashtables.c:830:5: warning: no previous prototype for function '__inet_bhash2_update_saddr' [-Wmissing-prototypes] int __inet_bhash2_update_saddr(struct sock *sk, struct inet_hashinfo *hinfo, ^ net/ipv4/inet_hashtables.c:830:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __inet_bhash2_update_saddr(struct sock *sk, struct inet_hashinfo *hinfo, ^ static 1 warning generated. vim +/__inet_bhash2_update_saddr +830 net/ipv4/inet_hashtables.c 828 829 /* the lock for the socket's corresponding bhash entry must be held */ > 830 int __inet_bhash2_update_saddr(struct sock *sk, struct inet_hashinfo *hinfo, 831 struct net *net, int port, int l3mdev) 832 { 833 struct inet_bind2_hashbucket *head2; 834 struct inet_bind2_bucket *tb2; 835 836 tb2 = inet_bind2_bucket_find(hinfo, net, port, l3mdev, sk, 837 &head2); 838 if (!tb2) { 839 tb2 = inet_bind2_bucket_create(hinfo->bind2_bucket_cachep, 840 net, head2, port, l3mdev, sk); 841 if (!tb2) 842 return -ENOMEM; 843 } 844 845 /* Remove the socket's old entry from bhash2 */ 846 __sk_del_bind2_node(sk); 847 848 sk_add_bind2_node(sk, &tb2->owners); 849 inet_csk(sk)->icsk_bind2_hash = tb2; 850 851 return 0; 852 } 853 -- 0-DAY CI Kernel Test Service https://01.org/lkp
