On Thu, 26 May 2022 04:50:17 +0200 Ingo Molnar <mingo@xxxxxxxxxx> wrote: > > The real fix would be to fix kallsyms to not show address of weak > > functions as the function before it. But that would require adding code in > > the build to add function size to kallsyms so that it can know when the > > function ends instead of just using the start of the next known symbol. > > Yeah, so I actually have a (prototype...) objtool based kallsyms > implementation in the (way too large) fast-headers tree that is both faster > & allows such details in principle: Nice. Will this work for other architectures too? > > If CONFIG_HAVE_FENTRY is defined for x86, define FTRACE_MCOUNT_MAX_OFFSET > > to zero, which will have ftrace ignore all locations that are not at the > > start of the function. > > > > [1] https://lore.kernel.org/all/20220412094923.0abe90955e5db486b7bca279@xxxxxxxxxx/ > > > > Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx> > > LGTM. > > I suppose you'd like to merge this via the tracing tree? If so: Yeah, I'll pull it through my tree. > > Acked-by: Ingo Molnar <mingo@xxxxxxxxxx> Thanks a lot Ingo for reviewing it. I really appreciate it! -- Steve
