Re: [PATCH bpf-next 03/12] bpftool: Use libbpf_bpf_prog_type_str

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 17, 2022 at 03:18:24PM +0100, Quentin Monnet wrote:
> 2022-05-16 17:35 UTC+0000 ~ Daniel Müller <deso@xxxxxxxxxx>
> > This change switches bpftool over to using the recently introduced
> > libbpf_bpf_prog_type_str function instead of maintaining its own string
> > representation for the bpf_prog_type enum.
> > 
> > Signed-off-by: Daniel Müller <deso@xxxxxxxxxx>
> > ---
> >  tools/bpf/bpftool/feature.c | 57 +++++++++++++++++++++++--------------
> >  tools/bpf/bpftool/link.c    | 19 +++++++------
> >  tools/bpf/bpftool/main.h    |  3 --
> >  tools/bpf/bpftool/map.c     | 13 +++++----
> >  tools/bpf/bpftool/prog.c    | 51 ++++++---------------------------
> >  5 files changed, 64 insertions(+), 79 deletions(-)
> > 
> > diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
> > index d12f460..a093e1 100644
> > --- a/tools/bpf/bpftool/feature.c
> > +++ b/tools/bpf/bpftool/feature.c
> 
> > @@ -728,10 +724,10 @@ probe_helper_for_progtype(enum bpf_prog_type prog_type, bool supported_type,
> >  }
> >  
> >  static void
> > -probe_helpers_for_progtype(enum bpf_prog_type prog_type, bool supported_type,
> > +probe_helpers_for_progtype(enum bpf_prog_type prog_type,
> > +			   char const *prog_type_str, bool supported_type,
> 
> Nit: "const char*" for consistency?

Good catch. Yes, will make the change.

Thanks,
Daniel



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux