On Tue, May 03, 2022 at 05:20:26PM +0000, Delyan Kratunov wrote: > On Tue, 2022-05-03 at 14:30 +0800, kernel test robot wrote: > > Hi Delyan, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on bpf-next/master] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Delyan-Kratunov/sleepable-uprobe-support/20220503-071247 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > > config: i386-defconfig (https://download.01.org/0day-ci/archive/20220503/202205031441.1fhDuUQK-lkp@xxxxxxxxx/config ) > > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > > reproduce (this is a W=1 build): > > # https://github.com/intel-lab-lkp/linux/commit/cfa0f114829902b579da16d7520a39317905c502 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review Delyan-Kratunov/sleepable-uprobe-support/20220503-071247 > > git checkout cfa0f114829902b579da16d7520a39317905c502 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > All errors (new ones prefixed by >>): > > > > kernel/trace/trace_uprobe.c: In function '__uprobe_perf_func': > > > > kernel/trace/trace_uprobe.c:1349:23: error: implicit declaration of function 'uprobe_call_bpf'; did you mean 'trace_call_bpf'? [-Werror=implicit-function-declaration] > > 1349 | ret = uprobe_call_bpf(call, regs); > > | ^~~~~~~~~~~~~~~ > > | trace_call_bpf > > cc1: some warnings being treated as errors > > Hm, CONFIG_BPF_EVENTS doesn't seem to guard the callsite from trace_uprobe.c, it's > only gated by CONFIG_PERF_EVENTS there. A PERF_EVENTS=y && BPF_EVENTS=n config would > lead to this error. > > This is a pre-existing issue and I'll send a separate patch for it. Maybe move uprobe_call_bpf into trace_uprobe.c so it gets a chance of being fully inlined and will avoid this issue.
