On Sat, May 07, 2022 at 09:26:07AM +0800, Jason Xing wrote:
> On Sat, May 7, 2022 at 2:56 AM Peilin Ye <yepeilin.cs@xxxxxxxxx> wrote:
> >
> > Hi Jason,
> >
> > On Thu, May 05, 2022 at 09:08:26PM +0800, kerneljasonxing@xxxxxxxxx wrote:
> > > - pr_err("Attempt to release TCP socket in state %d %p\n",
> > > + pr_err("Attempt to release TCP socket in state %d %px\n",
> >
> > I think we cannot use %px here for security reasons? checkpatch is also
> > warning about it:
> >
>
> I noticed this warning before submitting. Since the %p format doesn't
> print the real address, printing the address here will be helpless and
> we cannot trace what exactly the bad socket is.
>
> What do you suggest?
How is a socket identified in places like /proc/<PID>/net/tcp ?
Could you print the local and remote port to identify the socket?
How does the address of the structure actually help you? Do you see
this address somewhere else?
Andrew
