On Mon, Apr 25, 2022 at 12:25 AM Jiri Olsa <olsajiri@xxxxxxxxx> wrote: > > On Fri, Apr 22, 2022 at 02:03:24PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Apr 22, 2022 at 12:00:23PM +0200, Jiri Olsa escreveu: > > > Moving the libbpf init code into single function, > > > so we have single place doing that. > > > > Cherry picked this one, waiting for Andrii to chime in wrt the libbpf > > changes, if its acceptable, how to proceed, i.e. in what tree to carry > > these? > > I think at this point it's ok with either yours perf/core or bpf-next/master, > I waited for them to be in sync for this ;-) I'd rather have all the libbpf code stay in bpf-next, otherwise Github sync process becomes very hairy. BTW, I think libbpf v0.8 release is pretty close, I plan to add few small features before cutting it, but that should be done pretty soon > > but as you pointed out there's issue with perf linked with dynamic libbpf, > because the current version does not have the libbpf_register_prog_handler > api that perf needs now.. also it needs the fix and api introduced in this > patchset > > I'll check and perhaps we can temporirly disable perf/bpf prologue generation > for dynamic linking..? until the libbpf release has all the needed changes > > jirka > > > > > - Arnaldo > > > > > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx> > > > --- > > > tools/perf/util/bpf-loader.c | 27 ++++++++++++++++++--------- > > > 1 file changed, 18 insertions(+), 9 deletions(-) > > > [...]