Re: [PATCH bpf-next v5 04/13] bpf: Tag argument to be released in bpf_func_proto

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 22, 2022 at 01:08:08AM IST, Kumar Kartikeya Dwivedi wrote:
> On Thu, Apr 21, 2022 at 09:49:54AM IST, Alexei Starovoitov wrote:
> > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > > index c802e51c4e18..97f88d06f848 100644
> > > --- a/kernel/bpf/verifier.c
> > > +++ b/kernel/bpf/verifier.c
> > > @@ -245,6 +245,7 @@ struct bpf_call_arg_meta {
> > >  	struct bpf_map *map_ptr;
> > >  	bool raw_mode;
> > >  	bool pkt_access;
> > > +	u8 release_regno;
> > >  	int regno;
> >
> > release_regno and regno are always equal.
> > Why go with u8 instead of bool flag?
> >
>
> Didn't realise that. I will change it.
>

Actually, I think regno may not equal release_regno. It is set by by
check_stack_range_initialized only when meta->raw_mode is true, along with
meta.access_size. So I skipped this change in v6.

--
Kartikeya



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux