On Thu, Apr 21, 2022 at 09:56:51AM IST, Alexei Starovoitov wrote: > On Fri, Apr 15, 2022 at 09:33:50PM +0530, Kumar Kartikeya Dwivedi wrote: > > return 0; > > } > > @@ -386,6 +388,7 @@ static void array_map_free_timers(struct bpf_map *map) > > struct bpf_array *array = container_of(map, struct bpf_array, map); > > int i; > > > > + /* We don't reset or free kptr on uref dropping to zero. */ > > if (likely(!map_value_has_timer(map))) > > It was a copy paste mistake of mine to use likely() here in a cold > function. Let's not repeat it. > Ok, will remove this and all the following ones that you pointed out. > > [...] -- Kartikeya
