Re: [PATCH bpf-next v2 1/7] bpf: Add MEM_UNINIT as a bpf_type_flag

[Joanne Koong <joannelkoong@xxxxxxxxx>]

On Mon, Apr 18, 2022 at 9:59 PM Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
>
> On Fri, Apr 15, 2022 at 11:34:23PM -0700, Joanne Koong wrote:
> > -     ARG_PTR_TO_UNINIT_MEM,  /* pointer to memory does not need to be initialized,
> > +     /* pointer to memory does not need to be initialized, helper function must fill
> > +      * all bytes or clear them in error case.
> > +      */
> > +     ARG_PTR_TO_MEM_UNINIT           = MEM_UNINIT | ARG_PTR_TO_MEM,
>
> Could you keep the name as ARG_PTR_TO_UNINIT_MEM ?
> This will avoid churn in all the lines below.
>
> > -     .arg2_type      = ARG_PTR_TO_UNINIT_MEM,
> > +     .arg2_type      = ARG_PTR_TO_MEM_UNINIT,
> ...
> > -     .arg2_type      = ARG_PTR_TO_UNINIT_MEM,
> > +     .arg2_type      = ARG_PTR_TO_MEM_UNINIT,
> ...
> > -     if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
> > +     if (fn->arg1_type == ARG_PTR_TO_MEM_UNINIT)
> >               count++;
> > -     if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
> > +     if (fn->arg2_type == ARG_PTR_TO_MEM_UNINIT)
> >               count++;
> > -     if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
> > +     if (fn->arg3_type == ARG_PTR_TO_MEM_UNINIT)
> >               count++;
> > -     if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
> > +     if (fn->arg4_type == ARG_PTR_TO_MEM_UNINIT)
> >               count++;
> > -     if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
> > +     if (fn->arg5_type == ARG_PTR_TO_MEM_UNINIT)
> >               count++;
> etc.
Will do - I'll make this edit for v3.