Re: [PATCH v3 bpf-next 5/7] libbpf: add x86-specific USDT arg spec parsing logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 6 Apr 2022, Andrii Nakryiko wrote:

> On Wed, Apr 6, 2022 at 3:49 PM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote:
> >
> > On Wed, 2022-04-06 at 10:23 -0700, Andrii Nakryiko wrote:
> > > On Mon, Apr 4, 2022 at 4:42 PM Andrii Nakryiko <andrii@xxxxxxxxxx>
> > > wrote:
> > > >
> > > > Add x86/x86_64-specific USDT argument specification parsing. Each
> > > > architecture will require their own logic, as all this is arch-
> > > > specific
> > > > assembly-based notation. Architectures that libbpf doesn't support
> > > > for
> > > > USDTs will pr_warn() with specific error and return -ENOTSUP.
> > > >
> > > > We use sscanf() as a very powerful and easy to use string parser.
> > > > Those
> > > > spaces in sscanf's format string mean "skip any whitespaces", which
> > > > is
> > > > pretty nifty (and somewhat little known) feature.
> > > >
> > > > All this was tested on little-endian architecture, so bit shifts
> > > > are
> > > > probably off on big-endian, which our CI will hopefully prove.
> > > >
> > > > Reviewed-by: Alan Maguire <alan.maguire@xxxxxxxxxx>
> > > > Reviewed-by: Dave Marchevsky <davemarchevsky@xxxxxx>
> > > > Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> > > > ---
> > >
> > > Ilya, would you be interested in implementing at least some limited
> > > support of USDT parameters for s390x? It would be good to have
> > > big-endian platform supported and tested. aarch64 would be nice as
> > > well, but I'm not sure who's the expert on that to help with.
> >

I'm definitely not the expert, but I've got aarch64 arg parsing working
and all usdt tests pass - I'll submit once Ilya's s390x patches land.

Alan



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux