On Wed, Apr 6, 2022 at 4:53 AM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Tue, Apr 5, 2022 at 6:09 AM Yafang Shao <laoar.shao@xxxxxxxxx> wrote: > > > > We have switched to memcg based memory accouting and thus the rlimit is > > not needed any more. LIBBPF_STRICT_AUTO_RLIMIT_MEMLOCK was introduced in > > libbpf for backward compatibility, so we can use it instead now. > > > > This patchset cleanups the usage of RLIMIT_MEMLOCK in tools/bpf/, > > tools/testing/selftests/bpf and samples/bpf. The file > > tools/testing/selftests/bpf/bpf_rlimit.h is removed. The included header > > sys/resource.h is removed from many files as it is useless in these files. > > > > - v3: Get rid of bpf_rlimit.h and fix some typos (Andrii) > > - v2: Use libbpf_set_strict_mode instead. (Andrii) > > - v1: https://lore.kernel.org/bpf/20220320060815.7716-2-laoar.shao@xxxxxxxxx/ > > > > Yafang Shao (27): > > bpf: selftests: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in > > xdping > > bpf: selftests: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in > > xdpxceiver > > bpf: selftests: No need to include bpf_rlimit.h in test_tcpnotify_user > > bpf: selftests: No need to include bpf_rlimit.h in flow_dissector_load > > bpf: selftests: Set libbpf 1.0 API mode explicitly in > > get_cgroup_id_user > > bpf: selftests: Set libbpf 1.0 API mode explicitly in > > test_cgroup_storage > > bpf: selftests: Set libbpf 1.0 API mode explicitly in > > get_cgroup_id_user > > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_lpm_map > > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_lru_map > > bpf: selftests: Set libbpf 1.0 API mode explicitly in > > test_skb_cgroup_id_user > > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sock_addr > > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sock > > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sockmap > > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_sysctl > > bpf: selftests: Set libbpf 1.0 API mode explicitly in test_tag > > bpf: selftests: Set libbpf 1.0 API mode explicitly in > > test_tcp_check_syncookie_user > > bpf: selftests: Set libbpf 1.0 API mode explicitly in > > test_verifier_log > > bpf: samples: Set libbpf 1.0 API mode explicitly in hbm > > bpf: selftests: Get rid of bpf_rlimit.h > > bpf: selftests: No need to include sys/resource.h in some files > > bpf: samples: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in > > xdpsock_user > > bpf: samples: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK in > > xsk_fwd > > bpf: samples: No need to include sys/resource.h in many files > > bpf: bpftool: Remove useless return value of libbpf_set_strict_mode > > bpf: bpftool: Set LIBBPF_STRICT_AUTO_RLIMIT_MEMLOCK for legacy libbpf > > bpf: bpftool: remove RLIMIT_MEMLOCK > > bpf: runqslower: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK > > > > Hey Yafang, thanks for the clean up! It looks good, but please make it > a bit more manageable in terms of number of patches. There is no need > to have so many tiny patches. Can you squash together all the > samples/bpf changes into one patch, all the selftests/bpf changes into > another, bpftool ones still can be just one patch. runqslower makes > sense to keep separate. Please also use customary subject prefixes for > those: "selftests/bpf: ", "bpftool: ", "samples/bpf: ". For runqslower > probably "tools/runqslower: " would be ok as well. > Thanks for your suggestion. I will change it. -- Thanks Yafang
