On Mon, 21 Mar 2022 08:01:11 +0100 Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > hi, > Andrii reported that backtraces from kprobe_multi program attached > as return probes are not complete and showing just initial entry [1]. > > Sending the fix together with bpf_get_func_ip inline revert, which is > no longer suitable. OK, this series looks good to me. Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx> Thank you, > > thanks, > jirka > > > --- > [1] https://lore.kernel.org/bpf/CAEf4BzZDDqK24rSKwXNp7XL3ErGD4bZa1M6c_c4EvDSt3jrZcg@xxxxxxxxxxxxxx/T/#m8d1301c0ea0892ddf9dc6fba57a57b8cf11b8c51 > > Jiri Olsa (2): > Revert "bpf: Add support to inline bpf_get_func_ip helper on x86" > bpf: Fix kprobe_multi return probe backtrace > > kernel/bpf/verifier.c | 21 +-------------------- > kernel/trace/bpf_trace.c | 68 +++++++++++++++++++++++++++++++++++++------------------------------- > 2 files changed, 38 insertions(+), 51 deletions(-) -- Masami Hiramatsu <mhiramat@xxxxxxxxxx>
