On Mon, Mar 21, 2022 at 4:02 PM Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, Mar 21, 2022 at 3:46 PM Alexei Starovoitov > <alexei.starovoitov@xxxxxxxxx> wrote: > > > > The following pull-request contains BPF updates for your *net-next* tree. > > No > > This is the tree that contains bad architecture code that was NAK'ed > by both x86 and arm64 people respectively. I missed the nacks. Did you look at the code? In particular: https://lore.kernel.org/bpf/164735286243.1084943.7477055110527046644.stgit@devnote2/ it's a copy paste of arch/x86/kernel/kprobes/core.c How is it "bad architecture code" ? > In particular, I think it's this part: > > > Masami Hiramatsu (11): > > fprobe: Add ftrace based probe APIs > > rethook: Add a generic return hook > > rethook: x86: Add rethook x86 implementation > > arm64: rethook: Add arm64 rethook implementation > > powerpc: Add rethook support > > ARM: rethook: Add rethook arm implementation > > fprobe: Add exit_handler support > > fprobe: Add sample program for fprobe > > fprobe: Introduce FPROBE_FL_KPROBE_SHARED flag for fprobe > > docs: fprobe: Add fprobe description to ftrace-use.rst > > fprobe: Add a selftest for fprobe > > That was added very late to the linux-next tree, and that causes build > warnings because of interactions with other changes. To be fair Masami's set got to v12 revision and was ready before Peter's endbr set. If I didn't miss any email the only known issue is missing endbr annotation.
