On Mon, Mar 7, 2022 at 8:45 PM Yuntao Wang <ytcoode@xxxxxxxxx> wrote: > > The trailing slash in LIBBPF_SRCS is redundant, it should be removed. > > But to simplify the Makefile further, we can set LIBBPF_INCLUDE to > $(srctree)/tools/lib directly, thus the LIBBPF_SRCS variable is unused > and can be removed. > > Signed-off-by: Yuntao Wang <ytcoode@xxxxxxxxx> > --- > v1->v2: get rid of LIBBPF_SRCS > Oops, didn't notice v2. But I ended up pushing the same thing in your v1, hope that's fine. > kernel/bpf/preload/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/bpf/preload/Makefile b/kernel/bpf/preload/Makefile > index 167534e3b0b4..7284782981bf 100644 > --- a/kernel/bpf/preload/Makefile > +++ b/kernel/bpf/preload/Makefile > @@ -1,7 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > > -LIBBPF_SRCS = $(srctree)/tools/lib/bpf/ > -LIBBPF_INCLUDE = $(LIBBPF_SRCS)/.. > +LIBBPF_INCLUDE = $(srctree)/tools/lib > > obj-$(CONFIG_BPF_PRELOAD_UMD) += bpf_preload.o > CFLAGS_bpf_preload_kern.o += -I $(LIBBPF_INCLUDE) > -- > 2.35.1 >
