Em Mon, Feb 28, 2022 at 03:05:21PM +0000, James Clark escreveu: > > > On 26/01/2022 16:07, German Gomez wrote: > > Adds a couple of perf_event_attr tests for the fix introduced in [1]. > > The tests check that the correct sample_period value is set in the > > struct perf_event_attr of the arm_spe events. > > > > [1]: https://lore.kernel.org/all/20220118144054.2541-1-german.gomez@xxxxxxx/ > > > > Signed-off-by: German Gomez <german.gomez@xxxxxxx> > > Reviewed-by: James Clark <james.clark@xxxxxxx> Thanks, applied. - Arnaldo > > --- > > tools/perf/tests/attr/README | 2 + > > tools/perf/tests/attr/base-record-spe | 40 +++++++++++++++++++ > > tools/perf/tests/attr/test-record-spe-period | 12 ++++++ > > .../tests/attr/test-record-spe-period-term | 12 ++++++ > > 4 files changed, 66 insertions(+) > > create mode 100644 tools/perf/tests/attr/base-record-spe > > create mode 100644 tools/perf/tests/attr/test-record-spe-period > > create mode 100644 tools/perf/tests/attr/test-record-spe-period-term > > > > diff --git a/tools/perf/tests/attr/README b/tools/perf/tests/attr/README > > index 1116fc6bf2ac..454505d343fa 100644 > > --- a/tools/perf/tests/attr/README > > +++ b/tools/perf/tests/attr/README > > @@ -58,6 +58,8 @@ Following tests are defined (with perf commands): > > perf record -c 100 -P kill (test-record-period) > > perf record -c 1 --pfm-events=cycles:period=2 (test-record-pfm-period) > > perf record -R kill (test-record-raw) > > + perf record -c 2 -e arm_spe_0// -- kill (test-record-spe-period) > > + perf record -e arm_spe_0/period=3/ -- kill (test-record-spe-period-term) > > perf stat -e cycles kill (test-stat-basic) > > perf stat kill (test-stat-default) > > perf stat -d kill (test-stat-detailed-1) > > diff --git a/tools/perf/tests/attr/base-record-spe b/tools/perf/tests/attr/base-record-spe > > new file mode 100644 > > index 000000000000..08fa96b59240 > > --- /dev/null > > +++ b/tools/perf/tests/attr/base-record-spe > > @@ -0,0 +1,40 @@ > > +[event] > > +fd=* > > +group_fd=-1 > > +flags=* > > +cpu=* > > +type=* > > +size=* > > +config=* > > +sample_period=* > > +sample_type=* > > +read_format=* > > +disabled=* > > +inherit=* > > +pinned=* > > +exclusive=* > > +exclude_user=* > > +exclude_kernel=* > > +exclude_hv=* > > +exclude_idle=* > > +mmap=* > > +comm=* > > +freq=* > > +inherit_stat=* > > +enable_on_exec=* > > +task=* > > +watermark=* > > +precise_ip=* > > +mmap_data=* > > +sample_id_all=* > > +exclude_host=* > > +exclude_guest=* > > +exclude_callchain_kernel=* > > +exclude_callchain_user=* > > +wakeup_events=* > > +bp_type=* > > +config1=* > > +config2=* > > +branch_sample_type=* > > +sample_regs_user=* > > +sample_stack_user=* > > diff --git a/tools/perf/tests/attr/test-record-spe-period b/tools/perf/tests/attr/test-record-spe-period > > new file mode 100644 > > index 000000000000..75f8c9cd8e3f > > --- /dev/null > > +++ b/tools/perf/tests/attr/test-record-spe-period > > @@ -0,0 +1,12 @@ > > +[config] > > +command = record > > +args = --no-bpf-event -c 2 -e arm_spe_0// -- kill >/dev/null 2>&1 > > +ret = 1 > > +arch = aarch64 > > + > > +[event-10:base-record-spe] > > +sample_period=2 > > +freq=0 > > + > > +# dummy event > > +[event-1:base-record-spe] > > diff --git a/tools/perf/tests/attr/test-record-spe-period-term b/tools/perf/tests/attr/test-record-spe-period-term > > new file mode 100644 > > index 000000000000..8f60a4fec657 > > --- /dev/null > > +++ b/tools/perf/tests/attr/test-record-spe-period-term > > @@ -0,0 +1,12 @@ > > +[config] > > +command = record > > +args = --no-bpf-event -e arm_spe_0/period=3/ -- kill >/dev/null 2>&1 > > +ret = 1 > > +arch = aarch64 > > + > > +[event-10:base-record-spe] > > +sample_period=3 > > +freq=0 > > + > > +# dummy event > > +[event-1:base-record-spe] -- - Arnaldo
