Re: [PATCH bpf-next v1 6/6] selftests/bpf: Add tests for kfunc register offset checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 03, 2022 at 04:56:37AM IST, Nathan Chancellor wrote:
> On Thu, Mar 03, 2022 at 04:44:01AM +0530, Kumar Kartikeya Dwivedi wrote:
> > On Thu, Mar 03, 2022 at 04:17:25AM IST, Alexei Starovoitov wrote:
> > > On Tue, Mar 1, 2022 at 3:57 AM Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx> wrote:
> > > >
> > > > On Tue, Mar 01, 2022 at 05:10:31PM IST, kernel test robot wrote:
> > > > > Hi Kumar,
> > > > >
> > > > > Thank you for the patch! Perhaps something to improve:
> > > > >
> > > > > [auto build test WARNING on bpf-next/master]
> > > > >
> > > > > url:    https://github.com/0day-ci/linux/commits/Kumar-Kartikeya-Dwivedi/Fixes-for-bad-PTR_TO_BTF_ID-offset/20220301-150010
> > > > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> > > > > config: s390-randconfig-r021-20220301 (https://download.01.org/0day-ci/archive/20220301/202203011937.wMLpkfU3-lkp@xxxxxxxxx/config)
> > > > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> > > >
> > > > The same warning is emitted on clang for all existing definitions, so I can
> > > > respin with a fix for the warning like we do for GCC, otherwise it can also
> > > > be a follow up patch.
> > >
> > > Separate patch is fine.
> > > How do you plan on fixing it?
> > > What is __diag_ignore equivalent for clang?
> >
> > Hmm, looks like I'll have to add those in include/linux/compiler-clang.h. Quick
> > local testing suggests it will work with _Pragma("clang diagnostic ignored ...").
>
> I have a diff that mirrors the GCC infrastructure, which should work for
> this, feel free to copy it:
>
> https://lore.kernel.org/r/20210310225240.4epj2mdmzt4vurr3@archlinux-ax161/
>
> If you want to shut up the warning for all supported versions of clang,
> switch 130000 for 110000 and __diag_clang_11() for __diag_clang_13().
>

That's great, Nathan! I'll add your Signed-off-by to it.

> Cheers,
> Nathan

--
Kartikeya



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux