Re: Re: [PATCH] ASoC: fsi: Add check for clk_enable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 01, 2022 at 08:44:12PM +0800, Mark Brown wrote:
>> +err:
>> +	clk_disable(clock->xck);
>> +	clk_disable(clock->ick);
>> +	clk_disable(clock->div);
> 
> You need separate labels for each enable so that we don't end up
> disabling clocks we didn't enable, that would also be a bug.

Thanks, I have submitted a v2 to fix it.

Jiang




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux