On Mon, Feb 28, 2022 at 04:53:44PM +0100, Daniel Borkmann wrote: > Hi Yan, > > On 2/23/22 11:28 AM, Yan Zhu wrote: > > Aggregating the code of the feature in the code file of the feature > > itself can improve readability and reduce merge conflicts. So move > > the bpf syscall sysctl table to kernel/bpf/syscall.c > > > > Signed-off-by: Yan Zhu <zhuyan34@xxxxxxxxxx> > > > > --- > > v1->v2: > > 1.Added patch branch identifier sysctl-next. > > 2.Re-describe the reason for the patch submission. > > I'm not applying it given there is very little value in this change, see also what > has been said earlier: > > https://lore.kernel.org/bpf/CAADnVQKmBoQEG1+nmrCg2ePVncn9rZJX9R4eucP9ULiY=xVGjQ@xxxxxxxxxxxxxx/ Daniel, sorry folk are seing you patches with crap commit logs. The justification should be made clearer: we're moving sysctls out of kernel/sysctl.c as its a mess. I already moved all filesystem sysctls out. And with time the goal is to move all sysctls out to their own susbsystem/actual user. kernel/sysctl.c has grown to an insane mess and its easy to run into conflicts with it. The effort to move them out is part of this. The commit logs should not suck though... Luis
