Re: [PATCH bpf v2] xsk: fix race at socket teardown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 28, 2022 at 2:21 PM Björn Töpel <bjorn.topel@xxxxxxxxx> wrote:
>
> On Mon, 28 Feb 2022 at 10:46, Magnus Karlsson <magnus.karlsson@xxxxxxxxx> wrote:
> >
> > From: Magnus Karlsson <magnus.karlsson@xxxxxxxxx>
> >
> > Fix a race in the xsk socket teardown code that can lead to a null
> > pointer dereference splat. The current xsk unbind code in
> > xsk_unbind_dev() starts by setting xs->state to XSK_UNBOUND, sets
> > xs->dev to NULL and then waits for any NAPI processing to terminate
> > using synchronize_net(). After that, the release code starts to tear
> > down the socket state and free allocated memory.
> >
> [...]
> >
> > v1 -> v2:
> > * Naming xsk_zc_xmit() -> xsk_wakeup() [Maciej]
> >
>
> Magnus,
>
> You forgot to include my ACK! So, again:
>
> Acked-by: Björn Töpel <bjorn@xxxxxxxxxx>

Sorry for that Björn.

/Magnus

>
> Cheers,
> Björn




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux