On Sat, Feb 26, 2022 at 8:37 AM Song Liu <song@xxxxxxxxxx> wrote: > > On Fri, Feb 25, 2022 at 8:32 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > [...] > > > > One comment about the patch series. You might want to break the patches > > up a bit smaller, having the example code in a separate commit from the > > "add this feature" commit, as it was hard to pick out what was kernel > > changes, and what was test changes from it. That way I can complain > > about the example code and tests without having to worry about the > > kernel patches. > > Echo on this part. Please organize kernel changes, libbpf changes, > maybe also bpftool changes, selftests, and samples into separate patches. > This would help folks without HID experience understand the design. > Sure. And thanks for the initial review. I'll send out a splitted v2 early next week then. Cheers, Benjamin
