On Wed, Feb 23, 2022 at 4:40 PM Mykola Lysenko <mykolal@xxxxxx> wrote: > > In particular: > 1) remove output of inv for scalars in print_verifier_state > 2) replace inv with scalar in verifier error messages > 3) remove _value suffixes for umin/umax/s32_min/etc (except map_value) > 4) remove output of id=0 > 5) remove output of ref_obj_id=0 > > Signed-off-by: Mykola Lysenko <mykolal@xxxxxx> > --- You could have preserved my ack, but LGTM again (assuming CI run is green): Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > kernel/bpf/verifier.c | 63 ++--- > .../testing/selftests/bpf/prog_tests/align.c | 218 +++++++++--------- > .../selftests/bpf/prog_tests/log_buf.c | 4 +- > .../selftests/bpf/verifier/atomic_invalid.c | 6 +- > tools/testing/selftests/bpf/verifier/bounds.c | 4 +- > tools/testing/selftests/bpf/verifier/calls.c | 6 +- > tools/testing/selftests/bpf/verifier/ctx.c | 4 +- > .../bpf/verifier/direct_packet_access.c | 2 +- > .../bpf/verifier/helper_access_var_len.c | 6 +- > tools/testing/selftests/bpf/verifier/jmp32.c | 16 +- > .../testing/selftests/bpf/verifier/precise.c | 4 +- > .../selftests/bpf/verifier/raw_stack.c | 4 +- > .../selftests/bpf/verifier/ref_tracking.c | 6 +- > .../selftests/bpf/verifier/search_pruning.c | 2 +- > tools/testing/selftests/bpf/verifier/sock.c | 2 +- > .../selftests/bpf/verifier/spill_fill.c | 38 +-- > tools/testing/selftests/bpf/verifier/unpriv.c | 4 +- > .../bpf/verifier/value_illegal_alu.c | 4 +- > .../selftests/bpf/verifier/value_ptr_arith.c | 4 +- > .../testing/selftests/bpf/verifier/var_off.c | 2 +- > 20 files changed, 202 insertions(+), 197 deletions(-) > [...]
