On Sat, Feb 19, 2022 at 11:27 PM Andrii Nakryiko <andrii@xxxxxxxxxx> wrote: > > There turned out to be a few problems with btfgen selftests. > > First, core_btfgen tests are failing in BPF CI due to the use of > full-featured bpftool, which has extra dependencies on libbfd, libcap, > etc, which are present in BPF CI's build environment, but those shared > libraries are missing in QEMU image in which test_progs is running. > > To fix this problem, use minimal bootstrap version of bpftool instead. > It only depend on libelf and libz, same as libbpf, so doesn't add any > new requirements (and bootstrap bpftool still implementes entire > `bpftool gen` functionality, which is quite convenient). > > Second problem is even more interesting. Both core_btfgen and core_reloc > reuse the same set of struct core_reloc_test_case array of test case > definitions. That in itself is not a problem, but btfgen test replaces > test_case->btf_src_file property with the path to temporary file into > which minimized BTF is output by bpftool. This interferes with original > core_reloc tests, depending on order of tests execution ah, good catch! Thanks for the fix!
