Hi Daniel, On Fri, Feb 11, 2022 at 03:39:48PM +0100, Daniel Borkmann wrote: > On 1/29/22 11:04 PM, Hou Tao wrote: > > It is a preparation patch for eBPF atomic supports under arm64. eBPF > > needs support atomic[64]_fetch_add, atomic[64]_[fetch_]{and,or,xor} and > > atomic[64]_{xchg|cmpxchg}. The ordering semantics of eBPF atomics are > > the same with the implementations in linux kernel. > > > > Add three helpers to support LDCLR/LDEOR/LDSET/SWP, CAS and DMB > > instructions. STADD/STCLR/STEOR/STSET are simply encoded as aliases for > > LDADD/LDCLR/LDEOR/LDSET with XZR as the destination register, so no extra > > helper is added. atomic_fetch_add() and other atomic ops needs support for > > STLXR instruction, so extend enum aarch64_insn_ldst_type to do that. > > > > LDADD/LDEOR/LDSET/SWP and CAS instructions are only available when LSE > > atomics is enabled, so just return AARCH64_BREAK_FAULT directly in > > these newly-added helpers if CONFIG_ARM64_LSE_ATOMICS is disabled. > > > > Signed-off-by: Hou Tao <houtao1@xxxxxxxxxx> > > Hey Mark / Ard / Will / Catalin or others, could we get an Ack on patch 1 & 2 > at min if it looks good to you? Sorry for the delay, for some reason this series has all ended up in my spam! I'll take a look this week. If it looks good, do you mind if I queue those two patches in arm64 on a stable branch for you to pull as well? We've got a few other (non-BPF) changes pending to the instruction decoder, and I'd like to avoid conflicts if we can. Cheers, Will