Re: [PATCH bpf-next v1 2/3] bpftool: skeleton uses explicitly sized ints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2022-02-10 at 14:42 -0800, Andrii Nakryiko wrote:
> if Alexei's patch set will go in first (very likely), you'll need to
> rebase and make sure that you don't include either inttypes.h or
> stdint.h for kernel mode, as those headers don't exist there

Ack.

> seems like inttypes.h just includes stdint.h, I'd just include stdint.h directly

You need inttypes.h for the PRIxxx format specifiers and I figured users of
skels are not unlikely to want to print things. Happy to move it to just
stdint.h though.

> we don't use PRIxxx ugliness anywhere in selftests or libbpf code
> base, it would be easier to just convert this to ASSERT_EQ()
> 

Sure, can do.
> 




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux