On Thu, 10 Feb 2022 16:40:28 +0000 "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote: > The other option is to mark ftrace_cmp_recs() as a __weak function, but > I have a vague recollection of you suggesting #ifdef rather than a > __weak function in the past. I might be mis-remembering, so if you think > making this a __weak function is better, I can do that. No. If I wanted that I would have suggested it. I think this is the prettiest of the ugly solutions out there ;-) As I said, I can't think of a better solution, and we can go with this until something else comes along. -- Steve