Re: [PATCH bpf-next] bpf, x86_64: fail gracefully on bpf_jit_binary_pack_finalize failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Feb 8, 2022, at 9:28 AM, Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote:
> 
> On Mon, Feb 7, 2022 at 10:26 PM Song Liu <song@xxxxxxxxxx> wrote:
>> 
>> Instead of BUG_ON(), fail gracefully and return orig_prog.
>> 
>> Fixes: 1022a5498f6f ("bpf, x86_64: Use bpf_jit_binary_pack_alloc")
>> Signed-off-by: Song Liu <song@xxxxxxxxxx>
>> ---
>> arch/x86/net/bpf_jit_comp.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c
>> index 643f38b91e30..08e8fd8f954a 100644
>> --- a/arch/x86/net/bpf_jit_comp.c
>> +++ b/arch/x86/net/bpf_jit_comp.c
>> @@ -2380,7 +2380,11 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)
>>                         *
>>                         * Both cases are serious bugs that we should not continue.
> 
> I tweaked that comment a bit, since it's no longer accurate and
> pushed to bpf-next.
> Thanks!

Thanks for the fix! I had that in mind initially, but forgot about it
when I got to the keyboard. 

Song




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux