On 2/4/22 3:58 PM, Stanislav Fomichev wrote:
This place also uses signed min_t and passes this singed int to copy_to_user (which accepts unsigned argument). I don't think there is an issue, but let's be consistent. Cc: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> Fixes: 7855e0db150ad ("bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature") Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
Agreed that there is no actual issue as the 'copy_size' should be small here (<= maximum skb total packet size). I tried to add -Wsign-conversion to kernel compilation and saw tons of warnings. I guess
we have to deal with case by case then. Acked-by: Yonghong Song <yhs@xxxxxx>